Contributing

This page shows some hints about the coding conventions.

Coding advices

CutterCore class

This is the main class where every link with r2 is made. It is unique accross the whole process. To access it, simply call Core().

Example:

Core()->getOffset();

Calling a radare2 command

There are two ways to do it: * CutterCore::cmd() (Discouraged) Only use it for commands which yells no output * CutterCore::cmdj() To be used with json commands like cmdj("agj") or cmdj("aflj"). It is way easier to parse a json output.

Example:

QJsonArray array = Core()->cmdj("pdj 1 @ main").array();

Seek the current file

To modify radare2 seek use CutterCore::seek(const RVA offset). This is important because it will emit a CutterCore::seekChanged(RVA offset) signal. Never ever call cmd("s offset");

Example:

Core()->seek(0x00C0FFEE);

Creating a widget

Make sure to connect the CutterCore::seekChanged(RVA offset) signal so your widget refreshes its output when radare2 seek is modified (switching to another function, etc.).

General coding guidelines

Coding style

In general, we follow the official Qt guidelines to format the code. If in doubt, you can use AStyle 2.06 to format the code. The command line for formatting the code according to the style is:

astyle --project=src/Cutter.astylerc src/filename.cpp

In contrast to the official guidelines of Qt, in Cutter we always use curly braces in conditional statements, even if the body of a conditional statement contains only one line.

// Wrong
if (address.isEmpty())
   return false;

// Correct
if (address.isEmpty()) {
   return false;
}

// Wrong
for (int i = 0; i < 10; ++i)
   qDebug("%i", i);

// Correct
for (int i = 0; i < 10; ++i) {
   qDebug("%i", i);
}

Includes

Always try to include only the needed definitions inside any header file. The less include in a header file, the better. That is that a header file is meant to be included elsewhere, and we want to avoid to trigger every file compilation when developping because of a single change in a header file.

If you only need to know that a class exists but don’t need the prototype, you can declare the class like this:

class MyClassThatExists;

/** ... **/

private:
    MyClassThatExists *classInstance;

And then include the class header inside your .cpp so you can use that class.

If you need something in the source file (.cpp) that is not a class member, then add the include in the source file.

The includes must be ordered from local to global. That is you will first include any local header file (with doublequotes like #include “common/Helpers.h”. Then after an empty newline you can include Qt definitions like #include <QShortcut>. And then after when needed, include the standard C++ headers you need.

Includes must be sorted by alphabetical order.

Docstrings

Our API reference is generated using Doxygen, so when it comes to function documentation, please use the following format:

/**
 * @brief Add a new param to the accumulator
 */
virtual void accumulate(RefreshDeferrerParams params) =0;

Loops

We use C++11 foreach loop style which means any “foreach” loop should look like:

for (QJsonValue value : importsArray) {
    doSomething(value);
}

nullptr

Please do not use 0 nor Q_NULLPTR, only use nullptr.

Example:

QObject *object = nullptr;

Connecting signals

To connect a signal to a slot, this is the preferred way to do it:

connect(sender, &QObject::destroyed, this, &MyObject::objectDestroyed);

The main reason is that this syntax allows the use of lambda functions.

Functions documentation

You can find the classes documentation in the API Reference menu item.